Conversation
ZibanPirate
requested changes
Dec 20, 2024
ZibanPirate
requested changes
Dec 20, 2024
…prove error handling in indexing
ZibanPirate
requested changes
Dec 20, 2024
ZibanPirate
requested changes
Dec 20, 2024
Member
ZibanPirate
left a comment
ZibanPirate
left a comment
There was a problem hiding this comment.
one more thing we forgot to do in #617 , otherwise API server won't bootstrap on cloud:
- add melisearch container in the other
api/oracle-cloud/docker-compose.ymlfile:
meilisearch:
image: getmeili/meilisearch:latest
ports:
- "7700:7700"
volumes:
- /home/ubuntu/app-data/api/meilisearch_db:/data.ms
environment:
MEILI_NO_ANALYTICS: true
MEILI_MASTER_KEY: "default"
- add
api/meilisearch_dbto.gitignore
ZibanPirate
requested changes
Dec 20, 2024
Member
ZibanPirate
left a comment
ZibanPirate
left a comment
There was a problem hiding this comment.
annnnd one last thing (i promise)
in both docker-compose files, the volume is not correct, should change data.ms to meili_data
ZibanPirate
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchServiceinstantiation.indexservice method to save new entries with their specific indexes.Type of change